Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): topology logos if possible #2521

Merged
merged 4 commits into from
Nov 18, 2024
Merged

feat(ui): topology logos if possible #2521

merged 4 commits into from
Nov 18, 2024

Conversation

talboren
Copy link
Member

@talboren talboren commented Nov 18, 2024 •
edited
Loading

close #2520

@vercel Vercel
Copy link

vercel bot commented Nov 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
keep ⬜️ Ignored (Inspect) Visit Preview Nov 18, 2024 1:08pm

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. UI User interface related issues labels Nov 18, 2024
shahargl
shahargl approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@shahargl shahargl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 18, 2024
@talboren talboren enabled auto-merge (squash) November 18, 2024 13:08
@talboren talboren merged commit ddcf62d into main Nov 18, 2024
10 of 12 checks passed
@talboren talboren deleted the feat/topology-logos-if-possible branch November 18, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahargl shahargl shahargl approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files. UI User interface related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[➕ Feature]: Show topology service icon if category is available
2 participants
@talboren @shahargl